ext/pdo_pgsql: Remove new PDO class constant specific to PGSQL driver #16755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
approved these changes
Nov 11, 2024
|
Note that this constant is already documented: https://www.php.net/manual/en/ref.pdo-pgsql.php#pdo-pgsql.constants |
There was a problem hiding this comment.
Thanks! It seems we need to fix the way we specify the class.
If we don't specify the class in the FQCN, it will be assumed that it doesn't exist and the test will be skipped.
(Even if php>=8.4, this function may not be supported if the linked client library libpq is an extremely old version, so this skip judgment is necessary.)
Co-authored-by: KentarouTakeda <takeda@youmind.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant is set on the new Pgsql driver and the purpose of those new subclasses is to handle those sort of constants.
Remove this being set on the PDO class before this version is actually released.
Requires RM approval: @php/release-managers-84