Skip to content

Fix GH-16723: CURLMOPT_PUSHFUNCTION issues #16732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 8, 2024

We copy the source handler's FCCs to those of the destination.

We also fix the erroneous test assumption that the trampoline wouldn't
be called.

We copy the source handler's FCCs to those of the destination.

We also fix the erroneous test assumption that the trampoline wouldn't
be called.
@cmb69 cmb69 changed the title don't copy to yourself Fix GH-16723: CURLMOPT_PUSHFUNCTION issues Nov 8, 2024
@cmb69 cmb69 linked an issue Nov 8, 2024 that may be closed by this pull request
@cmb69 cmb69 marked this pull request as ready for review November 8, 2024 19:30
@cmb69 cmb69 requested a review from adoy as a code owner November 8, 2024 19:30
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@cmb69 cmb69 closed this in 3a1a205 Nov 9, 2024
@cmb69 cmb69 deleted the cmb/gh16723 branch November 9, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CURLMOPT_PUSHFUNCTION issues on Ubuntu 24.04 (Curl 8.5.0)
2 participants