Fix array_all function description in array.c #16731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! However, it seems to me that either description is not correct; it's not about finding elements, but rather if elements satisfy a given predicate. See https://wiki.php.net/rfc/array_find, https://www.php.net/manual/en/function.array-all.php and https://www.php.net/manual/en/function.array-any.php, respectively. |
…ficial documentation
|
Yes, I know, I just wanted to stay as relevant as possible to the description already present. |
cmb69
approved these changes
Nov 8, 2024
|
Since this is your first php-src PR: it has not been merged according to Github, but it has been applied to PHP-8.4 and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior descriptions were identical for both functions
array_anyandarray_all, which could create confusion.