Skip to content

Close GH-16659: Bump ICU requirement to ICU >= 57.1 #16688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Close GH-16659: Bump ICU requirement to ICU >= 57.1 #16688

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 3, 2024

This requirements bump should rarely affect anybody in practice. All major distros already ship more recent ICU versions, and even for Solaris 11, ICU 57.1 is available via OpenCSW. Note that ICU 57.1 has been released on 2016-03-23[1].

[1] https://icu.unicode.org/download/57

Local test results

before:

Number of tests :   522               411
Tests skipped   :   111 ( 21.3%) --------
Tests warned    :     0 (  0.0%) (  0.0%)
Tests failed    :     0 (  0.0%) (  0.0%)
Expected fail   :     1 (  0.2%) (  0.2%)
Tests passed    :   410 ( 78.5%) ( 99.8%)

after:

Number of tests :   457               411
Tests skipped   :    46 ( 10.1%) --------
Tests warned    :     0 (  0.0%) (  0.0%)
Tests failed    :     0 (  0.0%) (  0.0%)
Expected fail   :     1 (  0.2%) (  0.2%)
Tests passed    :   410 ( 89.7%) ( 99.8%)

@cmb69
Close phpGH-16659: Bump ICU requirement to ICU >= 57.1
5152b31 
This requirements bump should rarely affect anybody in practice.  All
major distros already ship more recent ICU versions, and even for
Solaris 11, ICU 57.1 is available via OpenCSW.  Note that ICU 57.1 has
been released on 2016-03-23[1].

[1] <https://icu.unicode.org/download/57>
@cmb69 cmb69 linked an issue Nov 3, 2024 that may be closed by this pull request
Bump ICU version requirement #16659
Closed
devnexen
devnexen approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate the simplifications.

@cmb69
Copy link
Member Author

cmb69 commented Nov 3, 2024

I'll leave this open for a while. Maybe someone has objections.

@cmb69 cmb69 closed this in 3815a77 Nov 14, 2024
@cmb69 cmb69 deleted the cmb/gh16659 branch November 14, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump ICU version requirement
2 participants
@cmb69 @devnexen