Skip to content

ext/iconv fix solaris/illumos which can support const/non const versi… #16619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ext/iconv fix solaris/illumos which can support const/non const versi… #16619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec263fd
ext/iconv fix solaris/illumos which can support const/non const versi…
devnexen Oct 27, 2024
ca66f6a
trying w/o the feature_tests part ?
devnexen Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ext/iconv/iconv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@
#undef iconv
#endif

#if defined(__NetBSD__)
#if defined(__NetBSD__) || defined(__sun)
// unfortunately, netbsd has still the old non posix conformant signature
// libiconv tends to match the eventual system's iconv too.
//
// When the SUSv3 API is enabled, it switches to the alternative
// iconv api signature.
#define ICONV_CONST const
#else
#define ICONV_CONST
Expand Down