Add Dom\Element::insertAdjacentHTML() #16614
Conversation
nielsdos
force-pushed
the
dom-insert-adjacent-html
branch
2 times, most recently
from
8417dfd to
e028a00
Compare
|
According to the WHATWG issue, there's indeed a spec mistake. So the implementation here is correct after all. |
| xmlNodePtr context = NULL; | ||
|
|
||
| /* 3. Use the first matching item from this list: (...) */ | ||
| switch (ZSTR_LEN(where) + ZSTR_VAL(where)[2]) { |
There was a problem hiding this comment.
wtf
(edit: yes i see it, avoid strcmp for performance~)
There was a problem hiding this comment.
Similar trick is done in ext/random btw if you're curious
There was a problem hiding this comment.
We really need a mechanism to solve this in a generic fashion. The RoundingMode enum uses the same trick.
There was a problem hiding this comment.
Agreed. It would be useful to be able to compare enum elements, or at least their name, by address.
Maybe we can store the address of enum elements in some struct once they are instantiated. Storing them in the zend_class_entry would be ideal, but I'm not sure this is doable. Case classes may help with that. Alternatively we could store them in a separate struct generated in _arginfo.h.
|
LGTM 👍 |
nielsdos
force-pushed
the
dom-insert-adjacent-html
branch
from
e028a00 to
64083ff
Compare
|
No complaints were raised on the mailing list, I'm merging this. |
Blocked by whatwg/html#10725