Fix build of zend_shared_alloc.c when HAVE_MPROTECT is not defined #16570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Oct 25, 2024
| @@ -40,7 +33,7 @@ | |||
| # include <stdio.h> | |||
| #endif | |||
|
|
|||
| #ifdef HAVE_MPROTECT | |||
| #if defined(HAVE_MPROTECT) || defined(HAVE_MEMFD_CREATE) | |||
There was a problem hiding this comment.
I think it was because we did not want to enable memfd_create for FreeBSD.
One possible approach would be to do something like here at configure time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-16567
_GNU_SOURCEis always defined by the build system on Linux, so we can simply includesys/mman.hwhenHAVE_MEMFD_CREATEis defined.