Adapt tests for libxml2 >= 2.13.0 #16536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libxml2 2.13.0 introduced some relevant changes regarding the treatment of file paths on Windows[1]. Thus we un-xfail bug69753.phpt and its companion, and we adjust dom004.phpt. [1] <https://gitlab.gnome.org/GNOME/libxml2/-/commit/8ab1b122c47bfced2b59f52351507ebc1eb50218>
nielsdos
approved these changes
Oct 21, 2024
Perhaps so, that way we know by reading the code that the issue is fixed, and when we ever bump the requirement we can get rid of this cruft in the far future. |
Makes sense. I've pushed a respective commit. |
nielsdos
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxml2 2.13.0 introduced some relevant changes regarding the treatment of file paths on Windows[1]. Thus we un-xfail bug69753.phpt and its companion, and we adjust dom004.phpt.
[1] https://gitlab.gnome.org/GNOME/libxml2/-/commit/8ab1b122c47bfced2b59f52351507ebc1eb50218
I've tested locally against libxml2 2.13.4, and found no other issues for the seven test suites relevant for libxml.
I've targeted PHP-8.4 since I consider it somewhat unlikely that we're going to update stable branches to libxml2 2.13. Can rebase, though, if desired.
@nielsdos, I think https://gitlab.gnome.org/GNOME/libxml2/-/issues/611 is sufficiently fixed.
Not sure if we should update af2b066, since it's a pretty cheap comparison.