Unify headers already sent/session already started error handler #16451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now whenever we need to check where headers were already sent in ext/session, we call a single location that prints where, keeping it consistent output wise.
Similar to the one for headers.
This usually go hand in hand with the headers already sent checks, but is in a separate commit because of the amount of tests it changes.
Girgias
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies the error formatting for when a session was already started or headers were already sent in ext/session. This is an evolution of GH-16378, motivated by the fact some places were neglected with the additional checks. The additional checks add a lot of noise, so it's turned into a function.
This doesn't change control flow, as the error conditions as well as if any deinit needs to be happen is different per call site.