Skip to content

[skip ci] Group similar entries in UPGRADING #16420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Oct 13, 2024

This groups together:

  • Class constants being typed
  • Resource to object conversions
  • New warnings and exceptions

Motivation for this is to make it easier to write the migration guide, as we kinda group these sorts of things together anyway.

This groups together:
- Class constants being typed
- Resource to object conversions
- New warnings and exceptions
@Girgias Girgias requested a review from cmb69 October 13, 2024 17:54
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new grouping makes sense to me. I'm not sure about using > as bullets; maybe just use . again?

@Girgias Girgias requested a review from cmb69 October 15, 2024 14:37
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! A couple of nits, although not directly related to the re-grouping.

Girgias and others added 2 commits October 15, 2024 19:35
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@Girgias Girgias merged commit 9a4ec40 into php:PHP-8.4 Oct 15, 2024
2 checks passed
@Girgias Girgias deleted the 8.4-upgrading-4 branch October 15, 2024 18:38
Girgias added a commit that referenced this pull request Oct 15, 2024
* PHP-8.4:
  [skip ci] Group similar entries in UPGRADING (#16420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants