Free internal_runtime_cache on shutdown for NTS

[cmb69]

The internal runtime cache is never freed for NTS builds; as a stop- gap measure we disable the leak detection.

---

The leak is detected by the CRT debug heap (e.g. when running the ext/zend_test test suite), likely as of 25d7616. I don't know whether that change introduced, or merely exhibited the issue.

[bwoebi]

That's an oversight. In ZTS it's freed in compiler_globals_dtor, but in NTS that function isn't executed.
For NTS, compiler globals shutdown essentially happens within zend_shutdown().

That #else directive within zend_shutdown should include if (CG(internal_run_time_cache)) { pefree(CG(internal_run_time_cache), 1); CG(internal_run_time_cache) = NULL; }.
(Just marking the leak not checked obviously works, but isn't quite the point of it.)

(To be honest, it is quite confusing that there are different codepaths for NTS and ZTS. I'd say both should end up calling compiler_globals_dtor, and then you'd #ifdef ZTS the stuff you don't need in NTS there...)

[cmb69]

Thanks @bwoebi. I wasn't sure whether the current behavior is intentional; after all the memory is freed when the process terminates anyway.

To be honest, it is quite confusing that there are different codepaths for NTS and ZTS. I'd say both should end up calling compiler_globals_dtor, and then you'd #ifdef ZTS the stuff you don't need in NTS there...

Yeah, that seems to be reasonable.