curl: Prevent a CurlMultiHandle from holding onto a CurlHandle if add_handle fails
#16302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_handle` fails As a user I expect `curl_multi_add_handle` to not have any effect if it returns an error and I specifically do not expect that it would be necessary to call `curl_multi_remove_handle`.
TimWolla
added a commit
that referenced
this pull request
Oct 9, 2024
* PHP-8.2: curl: Prevent a CurlMultiHandle from holding onto a CurlHandle if `add_handle` fails (#16302)
TimWolla
added a commit
that referenced
this pull request
Oct 9, 2024
* PHP-8.3: curl: Prevent a CurlMultiHandle from holding onto a CurlHandle if `add_handle` fails (#16302)
TimWolla
added a commit
that referenced
this pull request
Oct 9, 2024
* PHP-8.4: curl: Prevent a CurlMultiHandle from holding onto a CurlHandle if `add_handle` fails (#16302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user I expect
curl_multi_add_handleto not have any effect if it returns an error and I specifically do not expect that it would be necessary to callcurl_multi_remove_handle.