Skip to content

Fix various hooked object iterator issues #16281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix various hooked object iterator issues #16281

wants to merge 3 commits into from

Conversation

iluuu1994
Copy link
Member

Fixes GH-16185

What a gigantic pain in the ass 😄

@iluuu1994 iluuu1994 requested a review from arnaud-lb October 7, 2024 14:30
arnaud-lb
arnaud-lb reviewed Oct 7, 2024
View reviewed changes
@iluuu1994
Copy link
Member Author

Found two more issues:

  • The reverse shadowing previously mentioned didn't work correctly.
  • The check to prevent readonly properties from being references was missing.

Hopefully those were the last issues.

arnaud-lb
arnaud-lb approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iluuu1994 iluuu1994 closed this in d76ef13 Oct 8, 2024
@iluuu1994
Copy link
Member Author

Thank you @arnaud-lb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @arnaud-lb