Skip to content

Don't use recursion when transferring a DOM internal document pointer #16180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Oct 2, 2024

Recursion is typically slower than iteration, and furthermore, this can cause problems in theory with deep trees.

Recursion is typically slower than iteration, and furthermore, this can
cause problems in theory with deep trees.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I suppose if C would support tail call recursions this might be less of an issue.

@nielsdos
Copy link
Member Author

nielsdos commented Oct 3, 2024

Tail calls wouldn't help us here because this isn't primitive recursion.

@nielsdos nielsdos merged commit c77a129 into php:master Oct 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants