Fix nightly builds regarding libavif #16130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we're running LINUX_X64 Asan builds on ubuntu-20.04, where libavif-dev is not available, so apt-x64 fails. This PR is a follow up to PR php#16049 to pass the respective parameter to apt-x64, and to fix the conditional check in configure-x64. It might be clearer to just have an `avif` parameter or to pass the runner version to these actions, but this should do for now.
iluuu1994
approved these changes
Sep 30, 2024
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
Currently, we're running LINUX_X64 Asan builds on ubuntu-20.04, where libavif-dev is not available, so apt-x64 fails. This PR is a follow up to PR php#16049 to pass the respective parameter to apt-x64, and to fix the conditional check in configure-x64. It might be clearer to just have an `avif` parameter or to pass the runner version to these actions, but this should do for now. Closes phpGH-16130.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're running LINUX_X64 Asan builds on ubuntu-20.04, where libavif-dev is not available, so apt-x64 fails. This PR is a follow up to PR #16049 to pass the respective parameter to apt-x64, and to fix the conditional check in configure-x64.
It might be clearer to just have an
avifparameter or to pass the runner version to these actions, but this should do for now.@iluuu1994, what do you think? Does this needs to be applied to lower branches, too?