Skip to content

test(pdo_pgsql): Exclude pdo implicitly required by pdo_pgsql from EXTENSIONS #16116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KentarouTakeda
Copy link
Contributor

The EXTENSIONS written in pdo_pgsql tests are:

  • Both pdo and pdo_pgsql are declared
  • Only pdo_pgsql is declared

Both were mixed. However, if pdo_pgsql is installed, pdo will be present, so there is no need to specify both.

Therefore, I unified all tests to declare only pdo_pgsql.

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@devnexen devnexen merged commit 6fb81d2 into php:master Sep 29, 2024
9 of 10 checks passed
@KentarouTakeda KentarouTakeda deleted the refactor-pdo-pgsql-test-extensions branch September 29, 2024 07:23
@cmb69
Copy link
Member

cmb69 commented Sep 29, 2024

Note that the --EXTENSION-- section is not only used to check whether extensions are loaded, but also to load them if available as shared module. So, if pdo can be built as shared module (I'm not sure if it can), both would need to be explicitly listed (probably in the order pdo, pdo_pgsql).

jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants