Skip to content

Remove phpdbg binary during make clean #16085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb commented Sep 27, 2024

make clean does not remove the phpdbg binary. This is annoying because after rebuilding without phpdbg, make test will attempt to run phpdbg tests, which will fail if the binary is not compatible with extensions. E.g.:

./configure && make
make clean

./configure --disable-phpdbg --enable-zts && make

# phpdbg tests are not skipped because the binary exists
# but they fail because extensions can not be loaded
make test

Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thanks for syncing this.

@arnaud-lb arnaud-lb marked this pull request as ready for review September 27, 2024 14:24
@arnaud-lb arnaud-lb merged commit 4252545 into php:master Sep 27, 2024
9 of 10 checks passed
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants