Skip to content

pdo: Use zend_string_toupper in pdo_stmt_describe_columns #16047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

TimWolla
Copy link
Member

zend_string_toupper was only introduced in PHP 8.2 and thus it likely was not used here, since this code was last touched for PHP 8.0.

zend_string_toupper was only introduced in PHP 8.2 and thus it likely was not
used here, since this code was last touched for PHP 8.0.
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TimWolla TimWolla merged commit 3c8c0df into php:master Sep 25, 2024
10 checks passed
@TimWolla TimWolla deleted the pdo-describe-columns-to-upper branch September 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants