Fix assertion failure in generator dtor #16025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-15866. Related: GH-15158, GH-10462.
I don't remember why I assumed that a generator with the ZEND_GENERATOR_IN_FIBER flag (implying the generator is running) could only be dtor during shutdown, but this assumption was wrong. It can happen during GC, of course.
Unfortunately it means that we can not cache the result of
check_node_running_in_fiber()
anymore, so we may traverse the tree more than once. However we only ever call this function when collecting a Fiber, which I expect to be rare.This is already the 3rd follow up of GH-10462, so I considered this idea again, but since we can start fibers in destructors now, this is not trivial.