Fix regression on systems built without JIT #16024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regressing commit: 654b787 This was called if JIT was enabled or not. If not enabled, it'll result in an undeclared function warning and maybe a bad time in the linker. Gate the meat of this PHP-side function on if JIT is enabled (but keep it existing so PHP userland code works with or without JIT, OFC).
bwoebi
approved these changes
Sep 24, 2024
dstogov
approved these changes
Sep 24, 2024
NattyNarwhal
referenced
this pull request
Sep 24, 2024
Internally accessible via zend_jit_blacklist_function / externally via opcache_jit_blacklist. The functionality currently only affects tracing JIT, but may be extended to other JIT modes in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regressing commit: 654b787
This was called if JIT was enabled or not. If not enabled, it'll result in an undeclared function warning and maybe a bad time in the linker. Gate the meat of this PHP-side function on if JIT is enabled (but keep it existing so PHP userland code works with or without JIT, OFC).