Skip to content

Testing the ABI break labeler #15969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Sep 20, 2024

No description provided.

@cmb69 cmb69 force-pushed the cmb/abi-break-test branch from 4235946 to 56a3bf7 Compare September 20, 2024 22:34
@cmb69 cmb69 closed this Sep 20, 2024
@cmb69
Copy link
Member Author

cmb69 commented Sep 20, 2024

Okay, seems to work[TM]. If a commit changes a published header, the "ABI break" label will be added. Further commits undoing all changes to published headers will not have the "ABI break" label removed; this needs manual removal. But even after manual removal, further changes to published headers will set the "ABI break" label again.

I should note that the list of published headers in labeler.yml is not automatically generated; thus, any change regarding PHP_INSTALL_HEADERS() needs to be manually updated there.

@cmb69 cmb69 deleted the cmb/abi-break-test branch September 20, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant