Skip to content

Fix unsetting DOM properties #15891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix unsetting DOM properties #15891

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

This never did anything in lower versions, but on master this crashes because the virtual properties don't have backing storage. Just forbid it since it was useless to begin with.

@nielsdos
Fix unsetting DOM properties
71d3b98 
This never did anything in lower versions, but on master this crashes
because the virtual properties don't have backing storage. Just forbid
it since it was useless to begin with.
@nielsdos nielsdos mentioned this pull request Sep 14, 2024
Merged
arnaud-lb
arnaud-lb approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Do you intend to replace prop_handlers with hooks in the future?

@nielsdos nielsdos closed this in c9a4aba Sep 17, 2024
@nielsdos
Copy link
Member Author

nielsdos commented Sep 17, 2024 •
edited
Loading

Do you intend to replace prop_handlers with hooks in the future?

Maybe, certainly not anymore for 8.4.
The thing is though that property hooks now will require a PHP function call, which is expensive relative to what we have now. Especially as DOM nowadays uses cache slot for property read and write I think the current approach is hard to beat in terms of performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

Assignees
No one assigned
Labels
Extension: dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @arnaud-lb