Add $outerHTML property to DOM #15887
Conversation
The joys of a living specification ;) Thanks for the review! I'll write the mailing list soon-ish to see if anyone objects and if I hear no complaints merge it. |
nielsdos
changed the title
There was a problem hiding this comment.
It's interesting seeing the tests call saveXML() instead of saveHTML().
Did you consider adding a test showing a situation where the DOM is unrepresentable?
$dom = DOM\HTMLDocument::createFromString( '<a href="#one"><p>Link</p></a>' );
$p = $dom->body->querySelector('p');
$p->outerHTML = '<a href="#two">Another Link</a>';
echo $dom->saveHTML();
// <html><head></head><body><a href="#one"><a href="#two">Another Link</a></a></body></html>I don't know if this is worthwhile, but it could clarify that it's following the spec and producing an invalid document.
|
@dmsnell Thanks for the input. In the end calling saveXML or saveHTML don't really matter that much. I'll add calls for saveHTML too. The more testing the better anyway. For the same reason I'll add your test as well. |
nielsdos
force-pushed
the
dom-outerHTML
branch
from
cc60546 to
f040af8
Compare
No description provided.