Skip to content

zend_compile.h: ZEND_ACC_DEPRECATED can be used for class constants #15848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

DanielEScherzer
Copy link
Member

Support for deprecating class constants was added to implement the PHP 8.3 deprecations in #11615, but the documentation update was missed.

[skip ci]

Support for deprecating class constants was added to implement the PHP 8.3
deprecations in php#11615, but the documentation update was missed.

[skip ci]
@DanielEScherzer
Copy link
Member Author

CC @Girgias - follow-up to your RFC implementation

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand which of my RFCs this is a follow-up, but the change to the comment is correct.

@Girgias Girgias merged commit 3c8fd93 into php:master Sep 12, 2024
2 checks passed
@DanielEScherzer
Copy link
Member Author

I don't understand which of my RFCs this is a follow-up, but the change to the comment is correct.

It was a follow-up to #11615

@DanielEScherzer DanielEScherzer deleted the patch-3 branch September 12, 2024 16:53
@Girgias
Copy link
Member

Girgias commented Sep 12, 2024

I had forgotten this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants