Support building ext/gd without libxpm on Windows #15846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For GD, libxpm is an optional dependency, and we should treat it as such, i.e. if the library is not found, we build ext/gd without XPM support. This should also be done for other optional dependencies (like libjpeg), but since we're close to PHP 8.4.0RC1, we postpone that. However, wrt libxpm[1] we're taking action immediately, so that we can ship builds without XPM support, or at least custom builds without XPM support are possible without modifying the sources. [1] <https://news-web.php.net/php.internals/125502>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GD, libxpm is an optional dependency, and we should treat it as such, i.e. if the library is not found, we build ext/gd without XPM support.
This should also be done for other optional dependencies (like libjpeg), but since we're close to PHP 8.4.0RC1, we postpone that. However, wrt libxpm[1] we're taking action immediately, so that we can ship builds without XPM support, or at least custom builds without XPM support are possible without modifying the sources.
[1] https://news-web.php.net/php.internals/125502