Skip to content

Sync Zend/asm/*_x86_64_sysv_elf_gas.S with upstream #15789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petk
Copy link
Member

@petk petk commented Sep 7, 2024

If I'm not mistaken there are duplicate code blocks in the php-src in these files. This looks ok or is this intentional that php-src doesn't have these synced with upstream?

There are duplicate code blocks in the php-src.
@devnexen
Copy link
Member

devnexen commented Sep 7, 2024

see #14027

@petk
Copy link
Member Author

petk commented Sep 7, 2024

Ok, great. I wasn't aware there is PR in progress happening here about this one. Then it's best to even fix it entirely there, yes. Thanks for finding this one...

@petk petk closed this Sep 7, 2024
@petk petk deleted the patch-asm-2 branch September 7, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants