Skip to content

Fix GH-15729 PDO tests name conflicts. #15765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-15729 PDO tests name conflicts. #15765

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Sep 5, 2024

No description provided.

@devnexen devnexen linked an issue Sep 5, 2024 that may be closed by this pull request
Conflicting debug_emulated_prepares.phpt #15729
Closed
cmb69
cmb69 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I still don't really understand how that clash happened, renaming the test shouldn't hurt, but should avoid such issues in the future.

Thank you!

@devnexen devnexen closed this in 3235817 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees
No one assigned
Labels
Extension: pdo_pgsql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting debug_emulated_prepares.phpt
2 participants
@devnexen @cmb69