Skip to content

Add missing returns in ext/date for PHP 8.3+ #15735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Sep 3, 2024

Issues originally found in #15598

Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but I am worried we didn't have a test case for one of the changes.

Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm and glad I asked about that test case :-)

@kocsismate kocsismate merged commit cb69900 into php:PHP-8.3 Sep 14, 2024
9 checks passed
@kocsismate kocsismate deleted the date-return-fix2 branch September 14, 2024 20:15
kocsismate added a commit that referenced this pull request Sep 14, 2024
* PHP-8.3:
  Add missing returns in ext/date for PHP 8.3+ (#15735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants