Skip to content

#[AllowDynamicProperties] validation: improve error messages #15734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DanielEScherzer
Copy link
Member

For traits and interfaces, include the name of the relevant trait (or interface) in the error message, the same way it is included for readonly classes.

@DanielEScherzer
Copy link
Member Author

CC @devnexen - patch per our discussion on #15733

@devnexen
Copy link
Member

devnexen commented Sep 3, 2024

makes sense to me

Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the nit

For traits and interfaces, include the name of the relevant trait (or
interface) in the error message, the same way it is included for readonly
classes.
@DanielEScherzer DanielEScherzer force-pushed the allowdynamicproperties-errors branch from 7bde0e8 to 498ae5a Compare September 4, 2024 20:25
@DanielEScherzer
Copy link
Member Author

LGTM except for the nit

Fixed

@kocsismate kocsismate merged commit f9d01e4 into php:master Sep 4, 2024
10 checks passed
@DanielEScherzer DanielEScherzer deleted the allowdynamicproperties-errors branch September 4, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants