Autotools: Sync CS in ext/odbc #15625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Obsolete backticks replaced with $(...); also backticks used inside AC_MSG_RESULT result in literal output. The $(...) works as intended and is executed in the shell with proper result message given - A couple of AS_VAR_IF used - Macro arguments quoted - Added simplistic macro definitions headers as done with other php-src M4 headers for consistency of reading the code
NattyNarwhal
approved these changes
Aug 28, 2024
|
We should probably look into other cleanups here, and see if we can get parity between PDO_ODBC and procedural in terms of supported driver managers. There's all sorts of special-casing in procedural. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(...), also backticks used inside AC_MSG_RESULT result in literal output. The$(...)works as intended and is executed in the shell with proper result message given