CI: Add 60-minute timeouts to GitHub Actions and Cirrus CI #15589
Conversation
|
This is motivated from CO2 emission guilt because I accidentally caused a test to hang forever and CI kept on going only until GitHub Actions killed it after full six hours. I didn't have permissions to cancel the build either (unless I force-push, which starts another run anyway). |
|
Rare occurrence, but I don't object to setting these. Most of these jobs are also executed in nightly. That said, some of them get pretty close to 50 minutes, either randomly or due to parallel load. https://github.com/php/php-src/actions/runs/10588551653/job/29341333738 |
|
@iluuu1994 thank you! You are right, I think 50 minutes is probably not within a reasonable tolerance. How about 60 minutes? gh run list --limit 500 --workflow push.ymlI took a look at all runs that took longer than 60 minutes. Some of the items seem to be wrong measurements, with |
There was a problem hiding this comment.
That said, some of them get pretty close to 50 minutes, either randomly or due to parallel load. https://github.com/php/php-src/actions/runs/10588551653/job/29341333738
42 minutes is still well below 50 minutes (~15% below). I don't particularly care about the specific number and agree that this change makes sense in general.
Currently, there are no explicit timeouts set for CI jobs, which means the CI jobs will keep running until they are terminated by the task runner. The current defaults of each provider are: - GitHub Actions: 360 minutes[^1] - Cirrus CI: 60 minutes[^2] - Travis CI: 50 minutes[^3] On Travis, the timeout is not configurable, and given that our test suite usually completes within 20 minutes, this commit explicitly sets timeouts for Cirrus CI and GitHub Actions to 50 minutes as well. [^1]: [GitHub Actions Workflow Syntax](https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes) [^2]: [Cirrus CI FAQ](https://cirrus-ci.org/faq/#instance-timed-out) [^3]: [Travis docs - customizing the build](https://docs.travis-ci.com/user/customizing-the-build#build-timeouts)
|
I think this is good to go. If there are issues, we can still increase the timeouts. Thank you, @Ayesh! |
|
yay, thank you! |
Currently, there are no explicit timeouts set for CI jobs, which means the CI jobs will keep running until they are terminated by the task runner. The current defaults of each provider are:
On Travis, the timeout is not configurable, and given that our test suite usually completes within 20 minutes, this commit explicitly sets timeouts for Cirrus CI and GitHub Actions to 50 minutes as well.
Footnotes
GitHub Actions Workflow Syntax ↩
Cirrus CI FAQ ↩
Travis docs - customizing the build ↩