Skip to content

Revert fix for GH-14930: truncating readdir output #15533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

bukka
Copy link
Member

@bukka bukka commented Aug 21, 2024

The fix was an ABI break so it needs to be reverted from 8.3.

@bukka bukka force-pushed the stream_dirent_size_abi_break branch from 2217213 to 32c557b Compare August 21, 2024 22:17
@bukka bukka changed the title Reverted fix for GH-14930: truncating readdir output Revert fix for GH-14930: truncating readdir output Aug 21, 2024
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@bukka bukka merged commit 70c5e36 into php:PHP-8.3 Aug 22, 2024
9 checks passed
@joec4i
Copy link
Contributor

joec4i commented Aug 22, 2024

Thanks @bukka . Does this mean extensions compiled against 8.3.10 would be broken in 8.3.11 too and they will have to be recompiled against 8.3.11? The number would be much lower for sure.

@bwoebi
Copy link
Member

bwoebi commented Aug 23, 2024

@joec4i The ABI break never made it to a release, it was fixed between RC1 and RC2.

@joec4i
Copy link
Contributor

joec4i commented Aug 23, 2024

@joec4i The ABI break never made it to a release, it was fixed between RC1 and RC2.

Hi @bwoebi It was part of the 8.3.10 release https://github.com/php/php-src/blob/php-8.3.10/NEWS#L64-L66 . If it's reverted, extensions built against 8.3.10 will be broken under 8.3.11. The impact will be much smaller though. Is it PHP's ABI compatibility policy that any breakage should be reverted?

@cmb69
Copy link
Member

cmb69 commented Aug 23, 2024

Yeah, that break unfortunately made it into 8.3.10, and as such needed to be reverted. See https://github.com/php/policies/blob/main/release-process.rst#release-cycle.

@joec4i
Copy link
Contributor

joec4i commented Aug 23, 2024

That makes sense! Thanks @cmb69 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants