-
Notifications
You must be signed in to change notification settings - Fork 7.9k
pdo_firebird: Cleanup code. #15510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdo_firebird: Cleanup code. #15510
Conversation
Remove unneeded `#if FB_API_VER >= 25`, `#if FB_API_VER >= 30`, `#ifdef SQL_BOOLEAN`
Support force_null for them.
…4 KB. The new limit is 10 MB, no one in their right mind would transmit a query of such length.
About eed7d2d: what about restoring a dump? In this case, we may have rather big queries, right? |
No. There is no support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I don't understand the SQL_TEXT
to SQL_VARYING
conversion that already happens, I trust you on this. Generally, this PR looks good to me.
Note that the Windows CI failure is unrelated (see PR#15518).
This is done for the purpose of unification. For other data types, we also convert them to SQL_TEXT if a string is supplied as a parameter. This code is shorter, and at the same time allows empty strings to be treated as NULL for enumerated data types. |
@SakiTakamachi, if you have no objections, I'll merge this tomorrow. |
I had been in poor health for a long time. This makes sense to me. |
Get well soon @SakiTakamachi! :) |
Since Firebird PDO now requires fbclient 3.0+ to compile, some conditional compilation directives are no longer needed in the code.