Zend: Make Closure covariant to callable #15492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
changed the title
|
What about all classes with |
I don't think there is an "easy" solution for this because PHP is nominally typed and there isn't an interface that is auto-implemented (or manually required) for classes that can be invoked. It could be done by inspecting the CE to see if the |
|
I see, makes sense, we'd need a |
Girgias
changed the title
arnaud-lb
approved these changes
Nov 11, 2024
Girgias
force-pushed
the
callable-variance
branch
from
e907b0e to
fec1664
Compare
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jan 28, 2025
Caused by phpGH-15492. While the parent might contain callable, it may also contain other types. zend_is_class_subtype_of_type() may be checking a member that is not callable itself. Discovered by a failing Laravel test in nightly.
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jan 28, 2025
Caused by phpGH-15492. While the parent might contain callable, it may also contain other types. zend_is_class_subtype_of_type() may be checking a member that is not callable itself. Fall back to the normal class subtype check. Discovered by a failing Laravel test in nightly.
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jan 28, 2025
Caused by phpGH-15492. While the parent might contain callable, it may also contain other types. zend_is_class_subtype_of_type() may be checking a member that is not callable itself. Fall back to the normal class subtype check. Discovered by a failing Laravel test in nightly.
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jan 28, 2025
Caused by phpGH-15492. While the parent might contain callable, it may also contain other types. zend_is_class_subtype_of_type() may be checking a member that is not callable itself. Fall back to the normal class subtype check. Discovered by a failing Laravel test in nightly.
iluuu1994
added a commit
that referenced
this pull request
Jan 28, 2025
Caused by GH-15492. While the parent might contain callable, it may also contain other types. zend_is_class_subtype_of_type() may be checking a member that is not callable itself. Fall back to the normal class subtype check. Discovered by a failing Laravel test in nightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out by @ondrejmirtes