PDO_Firebird: Add connection level SESSION_TIMEZONE attribute #15480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Aug 18, 2024
cmb69
reviewed
Aug 18, 2024
ext/pdo_firebird/tests/testdb.inc
Outdated
| @@ -14,15 +14,25 @@ define('PDO_FIREBIRD_TEST_DSN', getenv('PDO_FIREBIRD_TEST_DSN') ?: ''); | |||
|
|
|||
| if(!PDO_FIREBIRD_TEST_DSN) | |||
| { | |||
| die('Error: PDO_FIREBIRD_TEST_DSN must be set'); | |||
| die('Error: PDO_FIREBIRD_TEST_DSN must be set'); | |||
There was a problem hiding this comment.
I'd stick with 4 spaces as indentation in PHP files, but I don't think we have any CS in this regard.
|
I can't make an independent PR to clean up the code when there is an active PR. Now I know where I made a mistake. But it is not clear how to reassign a separate branch for an existing PR. |
3 tasks
Ah, I see. I suggest to just close this PR, and open up a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows you to set the session time zone when connecting to the database. An alternative is to set the time zone after the connection is established using the query: