Skip to content

Fix broken GCC compatibility #15447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

zeriyoshi
Copy link
Contributor

since #15408, ZTS builds now fail in GCC.

The cause is a header inclusion omission, which will be fixed.

Indentation format has also been fixed.

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeriyoshi zeriyoshi merged commit 836e6fa into php:PHP-8.2 Aug 16, 2024
6 of 8 checks passed
@zeriyoshi zeriyoshi deleted the fix_gcc_compat branch August 16, 2024 20:23
@zeriyoshi
Copy link
Contributor Author

I may have made a mistake in the NEWS merge operation. I have corrected it correctly as much as possible.

cmb69 added a commit that referenced this pull request Aug 20, 2024
* PHP-8.2:
  zend_max_execution_timer: fix gcc compatibility (#15447)
  [ci skip] fix NEWS
  [ci skip] Update NEWS
cmb69 added a commit that referenced this pull request Aug 20, 2024
* PHP-8.3:
  zend_max_execution_timer: fix gcc compatibility (#15447)
xtexx pushed a commit to AOSC-Tracking/php-src that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants