libtool: Don't remove gcov *.gcno file #15441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
This is also fixed in #13476 (I'll update the libtool in that PR soon to 2.5.1) so it has all recent updates in it for some modern compiler stuff).
Otherwise, we can add this patch in since the bundled libtool won't be upgraded for PHP-8.4.
petk
reviewed
Aug 16, 2024
Co-authored-by: Peter Kokot <peterkokot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libtool bundled with PHP is outdated and deletes
*.gcnofiles used by gcov during the build process.While this issue has already been resolved upstream, incorporating the fix at this point may not be practical. Therefore, we attempt to apply a fix to the current version.
This change will enable proper coverage output for third-party PHP Extensions.