Skip to content

ensure default settings used in test #15420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

ensure default settings used in test #15420

merged 1 commit into from
Aug 15, 2024

Conversation

remicollet
Copy link
Member

@remicollet remicollet commented Aug 15, 2024 •
edited
Loading

Test may fail with a php.ini installed setting not expected options (ex php.ini.production)

@remicollet remicollet requested a review from Girgias August 15, 2024 05:32
remicollet referenced this pull request Aug 15, 2024
@Girgias
[RFC] Convert exit (and die) from language constructs to functions (#…
a79c70f 
…13483)

RFC: https://wiki.php.net/rfc/exit-as-function
Girgias
Girgias approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah indeed good catch

@Girgias Girgias merged commit a6b7f13 into php:master Aug 15, 2024
10 checks passed
@remicollet remicollet deleted the issue-testexit branch August 15, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remicollet @cmb69 @Girgias