Autotools: Fix phpdbg build #15373
Merged
Autotools: Fix phpdbg build #15373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 04a67cd the list of source files are now added alphabetically. Previously the phpdbg_parser.c was added before the phpdbg_lexer.c. Which caused the "sapi/phpdbg/phpdbg_lexer.l:8:10: fatal error: 'phpdbg_parser.h' file not found" error. To make the order of source files irrelevant, the Makefile substitutions needs to be fixed - the 3rd argument of PHP_ADD_MAKEFILE_FRAGMENT macro, which is the substitution of the $(builddir) Make variable. The $(builddir)/phpdbg_lexer.lo was previously substituted to an absolute path. And the relative should be used, for Make to be able to find the dependent target.
|
Thank you @petk! |
devnexen
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 04a67cd the list of source files are now added alphabetically. Previously the phpdbg_parser.c was added before the phpdbg_lexer.c. Which caused the
"sapi/phpdbg/phpdbg_lexer.l:8:10: fatal error: 'phpdbg_parser.h' file not found" error.
To make the order of source files irrelevant, the Makefile substitutions needs to be fixed - the 3rd argument of PHP_ADD_MAKEFILE_FRAGMENT macro, which is the substitution of the
$(builddir)Make variable. The$(builddir)/phpdbg_lexer.lowas previously substituted to an absolute path. And the relative should be used, for Make to be able to find the dependent target.Fixes SjonHortensius/3v4l_org#22