Autotools: Sync CS in gd extension #15364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Obsolete PHP_* variables checks removed (there was once the 'pdf' extension bundled in PHP that also had the same --with-*-dir configure options (3be17e3). When combined with the gd extension, options need to be executed conditionally; first one won), this is no longer relevant neither recommended practice to duplicate configure options inside the php-src context. Ideally, all configure options should be prefixed with an extension namespace --with-<extension-name>-<option> to be unique. - AS_* macros used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--with-*-dirconfigure options (3be17e3). When combined with the gd extension, options need to be executed conditionally; first one won), this is no longer relevant neither recommended practice to duplicate configure options inside the php-src context. Ideally, all configure options should be prefixed with an extension namespace--with-<extension-name>-<option>to be unique.