ext/soap: Deprecate passing an int to SoapServer::addFunction() #15310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also deprecate SOAP_FUNCTIONS_ALL constant. RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_soap_functions_all_constant_and_passing_it_to_soapserveraddfunction
TimWolla
reviewed
Aug 9, 2024
ext/soap/soap.c
Outdated
Comment on lines
1208
to
1212
| php_error_docref(NULL, E_DEPRECATED, "Passing int is deprecated since 8.4," | ||
| " if all PHP functions need to be provided flatten the array returned by get_defined_functions()"); | ||
| if (UNEXPECTED(EG(exception))) { | ||
| RETURN_THROWS(); | ||
| } |
There was a problem hiding this comment.
I'd probably move this into the SOAP_FUNCTIONS_ALL case, because any other value emits an error anyways. Moving this, would allow to rephrase the error message as:
Enabling all functions via SOAP_FUNCTIONS_ALL is deprecated since 8.4, due to possible security concerns. If all PHP functions should be enabled, the flattened return value of get_defined_functions() can be used.
nielsdos
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deprecate SOAP_FUNCTIONS_ALL constant.
RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_soap_functions_all_constant_and_passing_it_to_soapserveraddfunction