Autotools: Sync CS in Zend.m4 #15304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petk
commented
Aug 8, 2024
petk
commented
- Autoconf sets the GCC variable to either "yes" if GNU C compatible compiler is detected (like gcc or clang) or to an empty value otherwise.
- AX_CHECK_COMPILE_FLAG arguments quoted and empty arguments trimmed
- Autoconf sets the GCC variable to either "yes" if GNU C compatible compiler is detected (like gcc or clang) or to an empty value otherwise. - AX_CHECK_COMPILE_FLAG arguments quoted and empty arguments trimmed
Girgias
approved these changes
Aug 8, 2024
Comment on lines
+192
to
+196
| dnl Check for support for implicit fallthrough level 1, also add after previous | ||
| dnl CFLAGS as level 3 is enabled in -Wextra. | ||
| AX_CHECK_COMPILE_FLAG([-Wimplicit-fallthrough=1], | ||
| [CFLAGS="$CFLAGS -Wimplicit-fallthrough=1"],, | ||
| [-Werror]) |
There was a problem hiding this comment.
Complete aside, I need to look at what the differences in levels are an if we maybe should increase it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.