ext/xml: Deprecate xml_set_object() and passing non-callable strings to handlers

[Girgias]

RFC: https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names

[nielsdos]

On mobile now, but looks like you missed updating some tests, I'll have a look once that's done.

[Girgias]

Erg, everything was passing locally

[nielsdos]

Implementation looks fine, only test + wording remarks

[jrfnl]

@Girgias I'm looking at the "Passing non-callable strings to the xml_set_*_handler() functions is now deprecated." part of the deprecation, in particular with respect to this: "This would also mean to unset a handler the value of null must be used instead of an empty string which is also currently allowed. "

It looks like there are no tests passing an empty string for the handler. And a quick test run also doesn't show a deprecation notice for an empty string as a callback: https://3v4l.org/AdVej/rfc#vgit.master

What am I missing ?

[Girgias]

It is producing a deprecation notice locally for me.

I am guessing 3v4l.org hasn't pulled the latest master yet.

I added a test.

[jrfnl]

@Girgias Thanks for clarifying and adding the test.

And good point about the master on 3v4l being behind. I may just be testing too early. Will check again in a few days.

[jrfnl]

FYI: pinged 3v4l about the master branch being behind (in principle it should update daily, so something has probably broken)