CI disable leak sanitizer on nightly temporarily, #15279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devnexen Oh, what I meant was declaring the |
|
ah right sorry |
the libedit dependency has a leak on wcsdup call on ubuntu focal
devnexen
force-pushed
the
disable_san_libedit
branch
from
fa09d1f to
ca27fc2
Compare
|
Would it make sense to report that upstream? I mean memory leaks might still be fixed even in that version. |
|
@cmb69 It's already fixed on newer versions of ubuntu, so I'm guessing its a known issue. But I'm not sure. I would have assumed that they would have fixed the old version if it were possible, or maybe it was fixed accidentally. |
|
Well, then it's probably okay to not bother with it, and just to disable the leak detection here. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libedit on ubuntu focal has a leak with a bunch of tests.