[JIT] Avoid generating fast property assign path for readonly properties #15260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dstogov I'm not sure if we need to handle |
readonly properties will usually be IS_UNDEF on assignment, dodging the fast path anyway. The fast path does not handle the readonly scope check. The alternative would be handling scope there, but since there are some many variants that might be more trouble than it's worth.
iluuu1994
force-pushed
the
jit-omit-readonly-fast-path
branch
from
8d305c8 to
e806c4d
Compare
|
@dstogov Thank you for confirming! |
Bilge
reviewed
Aug 20, 2024
| @@ -14435,7 +14435,13 @@ static int zend_jit_assign_obj(zend_jit_ctx *jit, | |||
| } else { | |||
| prop_ref = ir_ADD_OFFSET(obj_ref, prop_info->offset); | |||
| prop_addr = ZEND_ADDR_REF_ZVAL(prop_ref); | |||
| if (!ce || ce_is_instanceof || !(ce->ce_flags & ZEND_ACC_IMMUTABLE) || ce->__get || ce->__set || (prop_info->flags & ZEND_ACC_READONLY)) { | |||
| /* With the exception of __clone(), readonly assignment always happens on IS_UNDEF, doding | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readonly properties will usually be IS_UNDEF on assignment, dodging the fast path anyway. The fast path does not handle the readonly scope check. The alternative would be handling scope there, but since there are some many variants that might be more trouble than it's worth.