Update preprocessor macros help texts for enchant and snmp extensions #15255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Build System
Extension: enchant
Extension: snmp
labels
devnexen
reviewed
Aug 6, 2024
| @@ -12,7 +12,8 @@ if test "$PHP_ENCHANT" != "no"; then | |||
| PHP_EVAL_INCLINE([$ENCHANT2_CFLAGS]) | |||
| PHP_EVAL_LIBLINE([$ENCHANT2_LIBS], [ENCHANT_SHARED_LIBADD]) | |||
| AC_DEFINE([HAVE_ENCHANT_GET_VERSION], [1], | |||
| [enchant_get_version since 1.6.0]) | |||
| [Define to 1 if Enchant library has the 'enchant_get_version' function | |||
| (available since 1.6.0).]) | |||
There was a problem hiding this comment.
seems enchant is the only extension having this kind of info.
There was a problem hiding this comment.
I think it is kind of useful info to know in which version the function was added without the need to browse the library changelog...
devnexen
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of previous AC_DEFINE syncs to have better overview of what some macro is about.