Autotools: Add phpized configure log and help separators #15251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This quotes all PHP_CONFIGURE_PART arguments - When configuring and building extensions with phpize, this makes the './configure --help' and './configure' log output a bit more readable as it separates the extension configuration, Libtool configuration and the rest of the Autoconf and phpize configuration options. - The ./configure output separators bold tags are moved to the PHP_INIT_BUILD_SYSTEM macro to be available also in phpized extensions - The obsolete ticks `...` converted to the recommended $(...); Autoconf configure re-executes itself in shells where the $(...) still wouldn't work ok. For example, the default, initial, non-updated shell on Solaris 10. - Empty new lines in help separators synced (Autoconf default separators don't include additional empty newline after the separator title); so the PHP_HELP_SEPARATOR additional empty line is also removed (see './configure --help' output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(...);Autoconf configure re-executes itself in shells where the $(...) still wouldn't work ok. For example, the default, initial, non-updated shell on Solaris 10.