Skip to content

Fix SoapFault property destruction #15248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix SoapFault property destruction #15248

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Aug 5, 2024 •
edited
Loading

Two issues:

  1. We should not modify the object when we pass invalid values
  2. We should reset the properties to their default value otherwise we
    get a UAF.

Regressed in df219cc

@nielsdos
Fix SoapFault property destruction
5dec48c 
Two issues:
1) We should not modify the object when we pass invalid values
2) We should reset the properties to their default value otherwise we
   get a UAF.

Regressed in df219cc
Girgias
Girgias approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, apologies, I had it on my to-do list but didn't get round to it.

@nielsdos
Copy link
Member Author

nielsdos commented Aug 5, 2024

Ah yes, apologies, I had it on my to-do list but didn't get round to it.

nah it's fine

@nielsdos nielsdos closed this in 11fbe88 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: soap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias