Fix bug #51558: shared readline build fails #15242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'rl_pending_input' is a variable in Readline library and checking it
with PHP_CHECK_LIBRARY wouldn't find it on some systems. This should fix
the build on systems where this caused issues, such as AIX.
Which works on most systems but not on AIX mentioned in the bug as it
exports variables and functions differently whereas the linker couldn't
resolve the variable as a function.
The library check:
```c
char rl_pending_input ();
int main (void) {
return rl_pending_input ();
}
```
The declaration check:
```c
int main (void) {
(void) rl_pending_input;
(void) rl_pending_input;
;
return 0;
}
```
Closes https://bugs.php.net/51558
The realine.h is not self-contained header and needs all sorts of adjustments including the <stdio.h> included before. This fixes the issue on unpatched default readline installations, such as macOS.
|
Thanks for the review. Yes, I think this will work fine now (added also that missing <stdio.h> include). In the git commit message the |
petk
added a commit
to petk/php-src
that referenced
this pull request
Aug 6, 2024
This is a follow-up of phpGH-15242 (0b25e26) because the usmHMAC192SHA256AuthProtocol and usmHMAC384SHA512AuthProtocol are not functions but arrays. The AC_CHECK_DECL might be more appropriate and portable way to find these. [skip ci]
petk
added a commit
to petk/php-src
that referenced
this pull request
Aug 9, 2024
This is a follow-up of phpGH-15242 (0b25e26) because the usmHMAC192SHA256AuthProtocol and usmHMAC384SHA512AuthProtocol are not functions but arrays. The AC_CHECK_DECL might be more appropriate and portable way to find these.
petk
added a commit
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'rl_pending_input' is a variable in Readline library and checking it with PHP_CHECK_LIBRARY wouldn't find it on some systems. This should fix the build on systems where this caused issues, such as AIX.
Which works on most systems but not on AIX mentioned in the bug as it exports variables and functions differently whereas the linker couldn't resolve the variable as a function.
The library check:
The declaration check:
Closes https://bugs.php.net/51558