Skip to content

Keep context in filtered streams #15156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Keep context in filtered streams #15156

wants to merge 2 commits into from

Conversation

qkdreyer
Copy link
Contributor

@qkdreyer qkdreyer commented Jul 29, 2024 •
edited
Loading

Fixes: #15155

@qkdreyer qkdreyer requested a review from bukka as a code owner July 29, 2024 15:47
sandvige
sandvige reviewed Jul 29, 2024
View reviewed changes
bukka
bukka requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

bukka
bukka requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string length is surely incorrect and we don't use \ for core functions in tests.

@qkdreyer qkdreyer changed the title fix: keep context in filtered streams Keep context in filtered streams Jul 29, 2024
qkdreyer
qkdreyer commented Jul 29, 2024
View reviewed changes
@qkdreyer qkdreyer requested a review from bukka July 30, 2024 07:06
@qkdreyer
Copy link
Contributor Author

can we get this merged?

@cmb69
Copy link
Member

cmb69 commented Jul 31, 2024

can we get this merged?

No need to hurry; next PHP 8.4 pre-release (8.4.0beta1) is almost two weeks away. I'm quite sure that @bukka will have a look as soon as time permits.

And thank you for the PR!

@bukka bukka closed this in 7b32a14 Aug 6, 2024
@qkdreyer qkdreyer deleted the patch-1 branch August 7, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandvige sandvige sandvige left review comments

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Category: Streams Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream context is lost when custom stream wrapper is being filtered
4 participants
@qkdreyer @cmb69 @bukka @sandvige